Victor Berchet

Results 232 comments of Victor Berchet

@til-schneider @mourner What is the status here. I would love to this PR lands - I could help if something is missing or need to be updated. Please let me...

@mourner > Gosh. The project is very much alive and works perfectly for the purpose it was built for, and I could respond in detail on why this particular PR...

> Let's keep the discussion in #122. #122 has been closed by the maintainer. - it means discussion closed, no point in discussing there, - more generally it's never a...

I use https://github.com/timostamm/protobuf-ts which is a solid and well maintained TS implementation. You might want to check it out. On Sun, Jan 3, 2021, 17:26 Andrew Herron wrote: > @til-schneider...

That matches what I observed. Pbf is probably the best if bundle size is your primarily concern. On Mon, Jan 4, 2021, 03:39 Andrew Herron wrote: > I use https://github.com/timostamm/protobuf-ts...

A few thing I have tried: Use the same express settings as in the example: ` .use(session({secret: 'grant', saveUninitialized: true, resave: false}))` The outcome is the same. Try to get...

[The playground](https://grant.outofindex.com/) seems to works ok. It could be either a different config or a different framework... or more likely some error on my side !

> My only assumption right now is that for some reason the session is not being loaded when you get back to the redirect URL /oauth/google/callback. Could you please point...

Yep there is definitely something fishy with the session: `$ DEBUG=req,express-session,ioredis:* node app/server.js ` Before connection: ``` express-session no SID sent, generating session +809ms express-session no SID sent, generating session...

I think I found the culprit: ``` cookie: { maxAge: 3600, httpOnly: true, path: '/', sameSite: true, secure: USE_SECURE_COOKIES, }, ``` It looks like `sameSite: true,` causes the session cookie...