Vašek Henzl
Vašek Henzl
It would also be good to be able to order/group methods by a specified PhpDoc tag (e.g. `@api`).
Some of my thoughts from the first impression: - This PR seems to be solving more unrelated problems – directive printing and long lines/args/lists printing. Breaking it into more scoped...
Readability can be an issue, the last example is a good one. There actually has been some work done on that topic in the reference implementation (https://github.com/graphql/graphql-js/pull/2797). But in general,...
I think this is a bit more complicated. - There should be at least two template types - one on the `Promise` class, another on the `then()` method for `onFulfilled`,...
@simPod It works: https://phpstan.org/r/722e1db8-c329-4d69-a4fc-aa761ff5b5bf BTW, why two templates `T` and `R` in https://github.com/reactphp/promise/pull/188? Doesn't make sense IMO.
One more thing to consider is the variance of the generic type. I believe that `Promise` is covariant on `T`, not invariant. ```php /** @template-covariant T */ interface Promise {...
Another thing is that I believe the promise type is covariant on `T` (and `R`): https://github.com/webonyx/graphql-php/pull/1170#issuecomment-1155043969
> I don't understand the `in`/`out` syntax, I don't know which one is which. Any mnemonic help for that? TypeScript has a good explanation: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#optional-variance-annotations-for-type-parameters `in` is for _setters_ with...