Cheng Xing

Results 42 comments of Cheng Xing

Thanks for the catch! > The [CircuitSerializer](https://github.com/quantumlib/Cirq/blob/f3987d528156f1f746b73fd7b3ca9bdb7e0bd2c3/cirq-google/cirq_google/serialization/circuit_serializer.py#L31) continues to [set](https://github.com/quantumlib/Cirq/blob/f3987d528156f1f746b73fd7b3ca9bdb7e0bd2c3/cirq-google/cirq_google/serialization/circuit_serializer.py#L70) the [deprecated gate_set](https://github.com/quantumlib/Cirq/blob/f3987d528156f1f746b73fd7b3ca9bdb7e0bd2c3/cirq-google/cirq_google/api/v2/program.proto#L110) field on Program messages. This should be cleaned up, but is blocked by https://github.com/qh-lab/pyle/issues/29210 since the field...

Need to check how this interacts with server side replay functionality. The same solution for retrieving historical programs can likely be used for this.

@MichaelBroughton Marking this one before-1.0 since it potentially requires Devices changes. Please feel free to change it though if you think it's purely a feature addition.

Not sure if this has been done yet - cc @dstrain115 @mpharrigan

This PR is now stale - `get_qcs_objects_for_notebook()` has been updated to use the latest form, and `device.qubits` has been fixed. Will add logic to check processor health when picking a...

From Cirq sync - to what extent is classical controls broken by this? cc @MichaelBroughton @tanujkhattar @95-martin-orion

Marking as after 1.0 since this will be a feature addition and won't impact existing APIs. @95-martin-orion mentioned there are alternatives for realistic noise models, and if we do decide...

From Cirq sync - maybe call it `display_name` to avoid the name being used as an ID.

From Cirq sync - biggest question is whether changing text diagram output would be considered a breaking change.

From Cirq sync: reverting back to accepted. @viathor let us know if there's anything you'd like to discuss