Cheng Xing
Cheng Xing
From Cirq sync - this will be considered a bug fix as it returns the API behavior to the original intention.
From Cirq sync - worth looking into. Tentatively accepted, and as a next step, understand the difficulty around doing this, especially around packaging and serialization. This has been done before...
Pytest fixtures could potentially help us eliminate the hard requirement of declaring deprecations in tests. @pavoljuhas
This seems to trigger consistently when I induce an attach failure. ``` I0920 22:56:04.761145 1 reconciler.go:289] attacherDetacher.AttachVolume started for volume "pvc-1611b9 f2-bd28-11e8-b491-42010a800002" (UniqueName: "kubernetes.io/csi/com.google.csi.gcepd^us-central1-b/pvc-1611b9 f2-bd28-11e8-b491-42010a800002") from node "kubernetes-minion-group-zvl5" E0920 22:56:04.767041...
The tests might be just creating a copy of the StorageClass config. But for this specific test case, is `allowVolumeExpansion` set somewhere else in the test? Otherwise resize couldn't have...
/cc @saikat-royc @mattcary
Aside from that, it might be good to include `allowVolumeExpansion` in the configured storageclasses
Ah and `allowVolumExpansion` is explicitly set for "AllowExpansion" test patterns https://github.com/kubernetes/kubernetes/blob/c7d6f796fe30d3eb6ffd259693280329a7ada8f9/test/e2e/storage/testsuites/base.go#L244 and https://github.com/kubernetes/kubernetes/blob/c7d6f796fe30d3eb6ffd259693280329a7ada8f9/test/e2e/storage/testsuites/volume_expand.go#L69 This should be working as expected then