venksubramd
venksubramd
I think this one is pretty solid. I really like the documentation and the descriptions as well. One unrelated observation, going over the tests in P2pMPITests.cpp that use the MPI...
Nice work, addresses my previous comments. Thanks.
Nice work on this one @atulkulk I really like the builder pattern to configure the process, for example where a call to registerTest(...) is followed with .withEnvironment(), .withTimeout(), and so...
Nice changes. I especially like the warning for unexecuted tests when clear is called.
In the test files under test/ext-plugins/tests/ext-profiler each test has a "# Remove any existing trace files" section. Would it be worth to look at @pytest.fixture to provide the common code...
We have one test GraphRegisterDeregister. It invokes ncclCommGraphRegister and ncclCommGraphDeregister and checks the return value. Do we need to check the actual effect of these function calls, besides checking the...
I only have a few minor comments: test_broadcast.py: Some tests use mpirun with -np 4 whereas other tests use it with -np 8. Should we be running each of the...
> @venksubramd These are validation tests that can be run with a smaller number of processes (-np 4) to avoid generating large log files. We’ll be adding performance-related tests in...