Added new unit test for register.cc

[deeksha-amd]

Details

Work item: Internal

What were the changes?
This PR introduces one register test: GraphRegisterDeregister: To verify buffer registration and deregistration functions (ncclCommGraphRegister and ncclCommGraphDeregister) work correctly across all available GPUs

Why were the changes made? The new test improves the code coverage for register.cc file.

Approval Checklist

Do not approve until these items are satisfied.

• [ ] Verify the CHANGELOG has been updated, if
  • there are any NCCL API version changes,
  • any changes impact library users, and/or
  • any changes impact any other ROCm library.

[thananon]

CI failure at linking?

[deeksha-amd]

Hi @thananon This pull request depends on the following PR: https://github.com/ROCm/rccl/pull/1664

Once the above PR is merged, this one should pass CI and no longer fail. Let me know if you have any further questions.

[nileshnegi]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 2 pipeline(s).

[venksubramd]

We have one test GraphRegisterDeregister. It invokes ncclCommGraphRegister and ncclCommGraphDeregister and checks the return value. Do we need to check the actual effect of these function calls, besides checking the return value?

Do we need tests for other functions in the register.cc file? ncclRegFind ncclRegLocalIsValid ncclRegister regCleanup ncclRegCleanup ncclCommRegister_impl commDeregister ncclCommDeregister_impl

[deeksha-amd]

@venksubramd

1. Partially yes, it's more of an API sanity check and tests the intended lifecycle: allocate -> register -> deregister ->free
2. The new test added improves the code coverage from 90%(existing) to 100% for register.cc file. So, all the other functions are already covered.