Toon Verwerft

Results 280 comments of Toon Verwerft

Would it make sense to introduce an attribute for annotating the generics in the docs? It might be less confusing for PHP developers?

Yes, `@template` works well indeed. Would it also make sense to add `@pure` instead of showing it in those separate info elements?

Fyi : The docs web site on my phone tries to display the content in about half the available screen size. It is due to the borders and the margins....

Yes it did: https://wiki.php.net/rfc/locale_independent_float_to_string But PSL1 also supports PHP 74. So it's probably best to go for something like ```php sprintf('%.14F', $number) ``` But that means we need to specify...

Sorry for the confusion. I updated the issue. It's about coercing a float -> string. See https://github.com/azjezz/psl/blob/c34f75bcb27298a1fdb017c07cd90f07c78046e2/src/Psl/Type/Internal/StringType.php#L39

Sure, I'll give it a try later this week.

Scrolled to the source - but havent found much of those. Not sure if possible, but maybe one that covers all hash_algos? https://github.com/azjezz/psl/blob/1.9.x/src/Psl/Hash/algorithms.php

Gonna close this PR due to inactivity: The approach needs a full rewrite as mentioned in the comments. The issue is still open, so feel free to re-implement anytime.

Would it make sense to make the data structures immutable? That way the questions are answered with: * you can iterate a data structure * the result after iteration will...

The `dequeue` method in your example should also be immutable then? Meaning the while will need to reassign the parameter pointing to the new version of the queue as well...