Toon Verwerft

Results 280 comments of Toon Verwerft

FYI: closures are serialized in amphp through https://github.com/opis/closure We could indeed add something about it in our documentation, but it is mostly documented on the amphp pages : https://amphp.org/parallel-functions/ Having...

Hello, It should pass if one of the lines matches according to the implementation and testsuite. Can you provide a failing unit test? https://github.com/phpro/grumphp/blob/master/test/Unit/Task/Git/BranchNameTest.php#L96-L105 Thanks for the suggestion as well....

Sorry, don't have a lot of free time to spend on this atm. Did a quick test and it looks like it is an amphp/parallel (serialization) issue. If you disable...

I put some additional effort in this, but sadly no solution yet. What I found out, is that laraval/serializable-closure v1.2.0 is not able to succesfully serialize/unserialize the task. I added...

It might indeed be related to the sleep method in monologs base-handler. Currently not behind my computer for a couple of weeks, so feel free to play around with it.

Nice, thanks! Reopened: Maybe best to reflect this bug in our dependencies as well, so this package can't be installed with the known bug.

Not sure what is going wrong, it could be a couple of things. Can you validate these? * Are the files known by git when running grumphp? * Is the...

Why would you want to skip the hooks in that case? Doesn't it sound more reasonable to fail so that the root cause can be fixed by the owner of...

I'dd suggest to either 1. Commit with `-n` flag in those cases 2. Create your own git hook templates I don't think this is something we should add to this...