Toon Verwerft

Results 280 comments of Toon Verwerft

Adding an env var to toggle config_contains_finder to false on CI could also do the trick.

In that case, we might need a smarter way to set php-cs-fixer's intersection mode, which deals with the intersection of passing files and a finder https://github.com/phpro/grumphp/blob/3ec61c1678c4c370f02b05fef606fd561d923c8e/src/Task/PhpCsFixer.php#L91

The problem with that solution is that files that are ignored in the finder might be checked as well. Since it falls back to the originally provided `path-mode`. I don't...

That sure looks like an issue. Can you run grumphp with -vvv to see the phpstan command which is executed? Can you run that command separately and see if there...

Is this still an issue @soulcodex. If so, would it be possible to provide a repository that produces the isolated issue without the other tasks?

Hello @stijn-at-work The article has this note: > Note: The `fix_by_defaut` parameter will also be used in situations where CLI input is not supported. Depending on your CLI, this could...

@stijn-at-work cool! Not sure if that will work on all systems and in all situations. But If it does, I see no issue in adding it! This requires some additional...

Nice. Will also have to make sure it works on docker setups. Doesn't it overwrite the stdin stream and therefore skips the diff that if being piped into it? Meaning...

Thanks for reporting @bart-jaskulski. Configured myself some worktrees locally to see what is going on exactly. Looks like this implementation works. I did add some minor comments to make it...

@bart-jaskulski Got any time to look at the comments I added above? Is there anything else I can do to get this merged?