Toon Verwerft

Results 280 comments of Toon Verwerft

@ashokadewit Can you confirm the fix in #1147 would resolve the issue?

Hello, Thanks for the PR! I am a bit confused though: https://github.com/phpro/grumphp/blob/d855145f4f7121c96bdd72866e9788abce7024d5/src/Locator/ChangedFiles.php#L56-L70 The files should never contain any deleted files to begin with. Can you tell me more on how...

Hmm interesting. The dump autoload changes files, which might not be the wanted scenario here. Maybe it could make sense for composer to add this check to the validation command...

@peterjaap It's a nice feature... Care to finish up this PR? :)

> @veewee sure, but I've asked you some questions in the comments @peterjaap Is it possible you made those comments as part of a code review but did not submit...

When used wrong, dotenv-webpack can leak e.g. the database connection string into public JS code. I made a little plugin based on dotenv and define that only includes `PUBLIC_` prefixed...

@fhumanes Thanks for the example. It's a bit cumbersome, but it does the trick! (I've changed the implementation to `setComplexValue` in my end for better results.) It would be nice...

Sounds good: I'm all in on consistancy! I assume there will be a cs rule enforcing and fixing this for us somewhere.

I've had an offline discussion about this and there were some good arguments in favour and against this. Will add the main discussion points to this ticket later so that...

These were the main reasons that were holding back on implementing it: **There is no way in psalm (nor phpstan) to throw a generic exception:** https://psalm.dev/r/b3988674a5 ```php /** * @template...