psl icon indicating copy to clipboard operation
psl copied to clipboard

rename all parameters to use snake_case everywhere.

Open azjezz opened this issue 2 years ago • 3 comments

currently, functions use $snake_case for parameters, and methods use $camelCase, IMO, parameters should be $snake_case everywhere.

e.g:

$semaphore = new Async\Semaphore(concurrency_limit: $a, operation: $b);

instead of

$semaphore = new Async\Semaphore(concurrencyLimit: $a, operation: $b);

azjezz avatar Dec 22 '22 13:12 azjezz

cc @veewee WDYT?

azjezz avatar Dec 22 '22 13:12 azjezz

Sounds good: I'm all in on consistancy! I assume there will be a cs rule enforcing and fixing this for us somewhere.

veewee avatar Dec 22 '22 14:12 veewee

What is the reason not to do like in psr-12 ?

githubjeka avatar Jan 03 '23 14:01 githubjeka