grumphp icon indicating copy to clipboard operation
grumphp copied to clipboard
verified publisher icon phpro

Fix #912: Ignore deleted files in file_size task

Open jmdelehaye opened this issue 3 years ago • 2 comments

Q A
Branch master for features and deprecations
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets #912

This PR :

  • adds a FilesCollection->ignoreDeleted() method
  • uses this method in FileSize->run() to fix #912

NB: This dev was made on v1.5.1, due to my local PHP version.

jmdelehaye avatar Nov 25 '22 13:11 jmdelehaye

Hello,

Thanks for the PR! I am a bit confused though:

https://github.com/phpro/grumphp/blob/d855145f4f7121c96bdd72866e9788abce7024d5/src/Locator/ChangedFiles.php#L56-L70

The files should never contain any deleted files to begin with. Can you tell me more on how I can reproduce the issue?

veewee avatar Nov 29 '22 07:11 veewee