John Reeves

Results 19 comments of John Reeves

You should be able to at least store the stars locally and do what is (probably) the new behavior which is thumbs up for 4+, thumbs down for 3-.

I started work on this. My only concern is it's a lot of changes (as you've noted) because there are JSON.parse()/stringify() and misc localStorage calls or _OKCP.storage() calls all over....

I'm not sure what you mean about not handling async. The changes I made allow you to treat storage as if it is synchronous, so app code didn't have to...

I see. I didn't think there was more than a few K or maybe a few MB of data stored, so loading it into memory makes the most sense. If...

Just for what it's worth, this PR would be greatly appreciated and used immediately if I could. One of my main problems with Stencil is the fact that Props are...

oh hey, I didn't think to check existing pull requests before I did the same. I submitted PR #197 (and related issue #198). I'll take a look at this and...

Yeah, I'm fine with that. I admit I didn't spend much time on the tests. However, the file move I did was actually because my tests wouldn't run without it....

Thanks for the link, that export = xyz is exactly what I was looking for. I had already tested export default and ran into the same problem you did when...

#197 is my attempt at fixing this. It works when I use it for my case but I may have missed some corner cases.

Any news on this? kevinsperrine's commit looks like it will work. If no table name is present, it generates one. I mean it'd be nice to somehow tap into whatever...