Valentin Degenne
Valentin Degenne
I will never get the titles right..
@asyncLiz I followed the same idea as ``, however to be totally honest I don't know if that's good or not. Requesting your review.
Shouldn't this be left to the developer to decide? In the specifications GIF image you provided it's easy to tell it can be scrolled because the text is cropped, but...
Sorry I don't really have any arguments but for the sake of learning I want to ask why are they considered functions then? why not `openAnimation` and `closeAnimation` directly?
Oops sorry @asyncLiz I meant why they should be functions and not an object directly? ```js class Foo { openAnimation = DIALOG_DEFAULT_OPEN_ANIMATION // instead of getOpenAnimation() => DIALOG_DEFAULT_OPEN_ANIMATION } ```
It just caught my eyes in the docs that's all, I think functions are more handy yes. But in that case we might want to add the keyword `await` when...
I understand your complain is about the doc not being detailed enough, `v1.0` shipped recently and the doc is still in progress. Meanwhile here's a little tuto: You will need...
Firefox is doing great (you can even select text in the dialogs 😹)
@oeed I opened a PR but this repo is dead. Better fork it or find another one..
M3 for the win! :+1: