material-web icon indicating copy to clipboard operation
material-web copied to clipboard

fix(catalog): added fixed colors to the palette

Open vdegenne opened this issue 1 year ago • 3 comments

If you ever need to use fixed colors in some parts of the catalog, this PR adds them to the palette. It also sorts and prettify the keys of the materialColors object.

vdegenne avatar Feb 02 '24 19:02 vdegenne

I will never get the titles right..

vdegenne avatar Feb 02 '24 20:02 vdegenne

I will never get the titles right..

haha nw, sorry 😅

The catalog isn't really a "feature" of @material/web, but it'd be nice to call it out. I wish there was a "chore" or "note"/"misc" section for the changelog.

@e111077 d'you know why the preview-catalog action isn't running? I'm assuming it's a permission thing.

asyncliz avatar Feb 02 '24 20:02 asyncliz

it fails the following check:

github.event.label.name == 'preview-catalog' && github.event.pull_request.head.repo.full_name == github.repository

This was meant to prevent this from running on forked repos. We can remove that if you want. I'm not sure why it's there. It might be a holdover or maybe the action I took it from had a reason to prevent abuse? IIRC we had an action using up our resources simply from running on a developer's forked repo's local development (no intention on merging back)

e111077 avatar Feb 02 '24 21:02 e111077