vdbergh comments

Results 434 comments of


                                            vdbergh

Replace print by the Python logging framework

This is the code for the custom handler... ```python class EventHandler(logging.Handler): def __init__(self): super().__init__(level=logging.ERROR) logging.disable(level=logging.CRITICAL) rundb = RunDb(is_primary_instance=False) logging.disable(level=logging.NOTSET) self.actiondb = rundb.actiondb def emit(self, record): message=self.format(record) self.actiondb.log_message( username="fishtest.system", message=message, )...

Replace print by the Python logging framework

The logging section of `production.ini` ```ini [loggers] keys = root, fishtest [handlers] keys = console, events [formatters] keys = generic [logger_root] level = DEBUG handlers = console [logger_fishtest] level =...

Replace print by the Python logging framework

I am not sure I understand. The handler is already created with level equal to level.ERROR. I don’t understand the need for a further test in emit(). I am AFK...

Replace print by the Python logging framework

I changed the log levels from DEBUG to INFO and fixed a typo.

Replace print by the Python logging framework

I now reverted the root level to ERROR and set the fishtest level to DEBUG so that we can use `logger.debug(message)` inside Fishtest (for example to instrument code). According to...

Replace print by the Python logging framework

Squashed.

Replace print by the Python logging framework

I switched back to using a single main logger (this pattern is also used by other packages). The main logger is the logger `fishtest` which is a child of the...

Replace print by the Python logging framework

Rebased.

Replace print by the Python logging framework

Rebased

Replace print by the Python logging framework

@ppigazzini Could you maybe have a look at this PR? It seems like a nobrainer (replacing print by logger.info) and tying into the Python logger framework has many benefits for...