vdbergh

Results 172 comments of vdbergh

Sending the hostname is trivial but... On the worker side: the hostname should be added as a field to `worker_info`. I propose to have `--set_hostname ` for people that want...

There are three options. 1. Only send the hostname if the user wants it and show it only if the user is logged in/admin (the most restrictive option). 2. Only...

@ppigazzini The fact that the hostname is sometimes meaningless seems harmless. https://en.wikipedia.org/wiki/Nirvana_fallacy For me the only real issue is the privacy aspect. Do we trust the fishtest admins enough (now...

Well reporting hostname was explicitly requested by a user (see the OP)... I think a user provided worker name does not work since users copy config files between machines (I...

> About privacy in EU the data collected should be compliant to the [GDPR](https://ec.europa.eu/info/law/law-topic/data-protection/data-protection-eu_en), eg we should delete the sensible data upon the request of the user. > > That...

I still think that `--worker_name="foobar"` is not a good idea. A typical user will maybe enter it once, then copy the config file to the other servers under their control...

@ppigazzini Yes but that is only true if the argument of `--worker_name` is something sensible. Which I doubt if it is left to the users (e.g. the argument about copying...

But IMHO a user that runs a fleet of workers would just as well be served by `--report_hostname` I think (which was the original request).

> I don't know if should be easy to add the filtered out workers in the user page like we are doing for the tests. I am sorry. I do...

Ok for the `event_log` it is not so easy since the `worker_name` is created when the event happens, not when the log is watched. Fixable, but needs some thought.