vdbergh

Results 434 comments of vdbergh

Don't save the residuals and their colors in the db.

Of course we should use css to translate the symbolic colors `green`, `yellow`, `red` into actual hex-colors via an appropriate class instead of hard coding this translation in the Python...

Don't save the residuals and their colors in the db.

We could use an `Enum` `residual_color` and use that in the schema (it is just a type), but Enum's aren't used anywhere else in the Fishtest codebase. For now I...

Don't save the residuals and their colors in the db.

Rebased.

Don't save the residuals and their colors in the db.

> DEV running with the PR. The finished tests have the same residuals on PROD and DEV (checked the old ones as well). There are some on-going tests with time...

Don't save the residuals and their colors in the db.

I'll fix it after dinner. The new schema makes "bad_task" mandatory (I want to reduce the number of optional fields), but of course we still need to deal with old...

Don't save the residuals and their colors in the db.

You are right. It was a different problem. It should be fixed now. I also rebased.

Don't save the residuals and their colors in the db.

OMG. The same line.

Don't save the residuals and their colors in the db.

Another attempt. I am really unable to write correct code without testing.

Don't save the residuals and their colors in the db.

A static type checker would have caught this...

Don't save the residuals and their colors in the db.

> Thera are other purgeable runs (master and PR), they start with "#1974" if you want to check. I purged some and looked at the tasks (with the `get_task` api)...