vboussange
vboussange
> Thanks for these PRs, @vboussange ! In order for us to merge them, they will need comprehensive tests. > > Also, a formal review is forthcoming, but why are...
@KirillZubov yes, it would be great! I have not started any of those. You could try to implement `KolmogorovPDEProblem` and `NNStopping` on the branch https://github.com/SciML/HighDimPDE.jl/tree/NeuralPDE_integration, as well as transferring the...
The migration of NNPDENS and the associated test file is addressed in the specific issue https://github.com/SciML/HighDimPDE.jl/issues/30.
Work in progress on branch https://github.com/SciML/HighDimPDE.jl/tree/NeuralPDE_integration. Thanks to @ashutosh-b-b, the integration is almost completed and partially works. A major change is that now in HighDimPDE.jl, only one algorithm, `DeepBSDE`, replaces...
@ChrisRackauckas,@ashutosh-b-b, the PR is merged, but on the branch https://github.com/SciML/HighDimPDE.jl/tree/NeuralPDE_integration and not on the main branch, as stated above. @ashutosh-b-b, Could you take look at the test files `DeepBSDE_Han.jl` and...
> @ChrisRackauckas @vboussange the problem with some of the tests is `ambiguity` regarding methods on `Tracked` variables. For example: ` MethodError: vcat(::TrackedArray{…,Vector{Float32}}, ::Vector{Tracker.TrackedReal{Float32}}) is ambiguous` > > is what we...
## Review checklist for @vboussange ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
Hi everyone 👋 I am posting here my comments for the first round of review. ## General comments ### Reviewer summary DAISIEmainland is a package that allows to simulate the...
Both are interesting ideas. MLP could potentially be generalised, although I have some concerns about the numerical cost, as it heavily relies on nested calls.
@ChrisRackauckas Yes, it looks like only the Documentation action is triggered with PR. Do you have any idea why?