HighDimPDE.jl icon indicating copy to clipboard operation
HighDimPDE.jl copied to clipboard

Replace "map do" with Ensemble Simulations for DeepBSDE solver.

Open ashutosh-b-b opened this issue 2 years ago • 8 comments

ashutosh-b-b avatar Jun 30 '22 09:06 ashutosh-b-b

@vboussange can you have a look and merge?

ashutosh-b-b avatar Jun 30 '22 09:06 ashutosh-b-b

CI didn't run?

ChrisRackauckas avatar Jun 30 '22 10:06 ChrisRackauckas

@ChrisRackauckas Yes, it looks like only the Documentation action is triggered with PR. Do you have any idea why?

vboussange avatar Jun 30 '22 10:06 vboussange

The CI was set to branch-specific PR checking. Fixed.

ChrisRackauckas avatar Jun 30 '22 10:06 ChrisRackauckas

Why are the MLP.jl tests failing?

ashutosh-b-b avatar Jun 30 '22 11:06 ashutosh-b-b

Looks fine, but should probably figure out why tests are failing, and if that was happening before this PR.

ChrisRackauckas avatar Jun 30 '22 22:06 ChrisRackauckas

@ashutosh-b-b, the MLP tests were failing on the original branch NeuralPDE_integration, which I have fixed. Can you update your branch so that we can once again proceed to tests?

vboussange avatar Jul 18 '22 07:07 vboussange

@vboussange The non linear tests are failing due to a Zygote Error or rather a Tracker error. @ChrisRackauckas I mentioned this error earlier.

ashutosh-b-b avatar Jul 19 '22 10:07 ashutosh-b-b