Vatroslav Vrbanic

icon indicating a website link https://www.piratas-duesseldorf.de/

icon company piratas Werbeagentur GmbH + Co. KG icon location Düsseldorf, Germany icon location Sen. Creative Technologist at @piratas-gmbh in Düsseldorf, Germany

Results 84 issues of Vatroslav Vrbanic

`LoadedGLTF` : implement `crossorigin` prop

https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/LoadedGLTF.svelte#L163-L167

new feature
good first issue

`Scene` : check possible negative effect between `scene` / `root_scene` instances and `SvelthreeAnimation`

1 comment

https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/Scene.svelte#L203-L207

check / fix / polish
clarify
verify

`.userData` : reconsider current usage / type an interface (?) for data saved in `.userData`

Atm various svelthree properties are saved directly in `.userData` of three.js object instances, but it would be nice to have them more separated and typed (?) in an e.g. `userData.svelthree`...

decision needed
Types
refactor
API

`Scene`: verify (delete?) confusing comment / `scene.userData.animations` usage

- What was the exact intention behind adding `scene.userData.animations` (_even if it's not being used_)? - Has something similar been implemented instead? https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/Scene.svelte#L191-L194 https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/Scene.svelte#L252-L255

sweep
verify

`target: Targetable | boolean` : verify comment and review `target` functionality in general

The comment must be wrong / outdated + check / nail down the usage of `target` across all components. https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/SpotLight.svelte#L282-L286 https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/DirectionalLight.svelte#L283-L287

verify
review

`WebGLRenderer`: review `start_rendering()` and `stop_rendering()` methods

Should work as expected, but I did't test them enough (_use cases_). Test functionality and nail down usage. https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/WebGLRenderer.svelte#L759-L772

good first issue
review

`WebGLRenderer` : add 'split-like' rendering to different `<canvas>` elements

Atm, only 'mask-like' rendering to different `` elements is supported.

new feature

`WebGLRenderer`: describe possibilities and handling depending on component's position in markup

This is a cool feature, it works, but it needs more testing and description / clarification. https://github.com/vatro/svelthree/blob/ee5bec7edb9c6daae51820094039155f83c5e723/src/components/WebGLRenderer.svelte#L40-L54

clarify

`WebGLRenderer`: verify / nail down the 'cross-referencing' comment / `await tick()`

I remember when and why, but a lot has changed since, so this needs to be re-verified. https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/WebGLRenderer.svelte#L601-L604

verify

`WebGLRenderer`: refactor (rename?) `set_render(...)` method

It looks odd 🤔. https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/WebGLRenderer.svelte#L789-L794

refactor