svelthree icon indicating copy to clipboard operation
svelthree copied to clipboard
verified publisher icon vatro

`Scene` : check possible negative effect between `scene` / `root_scene` instances and `SvelthreeAnimation`

Open vatro opened this issue 3 years ago • 1 comments

https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/Scene.svelte#L203-L207

vatro avatar Jun 13 '22 11:06 vatro

The comment part // TODO / TOFIX this could cause problems with the 'SvelthreeAnimation' component which is checking 'currentSceneActive' is outdated / wrong, because there is no SvelthreeAnimation component anymore, so it should be deleted.

Nevertheless the handling of ``currentSceneActive` should be checked / polished / fixed.

vatro avatar Sep 23 '22 10:09 vatro

Ok, I've checked it. Didn't found nothing to worry about so far.

vatro avatar Dec 05 '22 20:12 vatro