Vatroslav Vrbanic

Results 84 issues of Vatroslav Vrbanic

Currently those are just `CustomEvent` revealing nothing about the contents of the `detail` object.

general
interaction
code quality

During refactoring of the `Mesh` component, certain parts / blocks of logic became much larger, breaking 1.100 lines of code, that's too much / frustrating to review. Currently, I'm generating...

general
code quality
maintenance

We're already doing it e.g. here: https://github.com/vatro/svelthree/blob/754a5f115ec0194e026426e2ce50518a573c4079/src/utils/SvelthreeGLTF.ts#L102 https://github.com/vatro/svelthree/blob/754a5f115ec0194e026426e2ce50518a573c4079/src/utils/SvelthreeGLTF.ts#L107-L111 by setting `context` to parent's context, but is this the proper / common way? Do Svelte people even do it / is...

clarify

I like snake case. The question is what to use for exposed props and methods. I've started with camel, then here and there switched to snake if I've found it...

API

- components destroyed / removed - three.js object instances removed from scene - three.js object instances added to different object / scene - components recreated (e.g. apply new mesh via...

good first issue
check / fix / polish

Review / improve WebGLRenderer component: - [ ] PixelRatio, resizing Canvas etc. - [ ] Extensive Mobile Test

DX
test
WebGLRenderer

- [ ] Deep check current workflow (animations etc.) 🧐 - [ ] Add Examples on svelthree.dev

DX
general
LoadedGLTF

- [ ] What to do with Loaders? At the moment we only have the **LoadedGLTF component**. Strongly tending to just leave the rest vanilla three.js, but need to check...

DX
discussion
decision needed

Matrix manipulation works (_should_), but has some quirks which need be properly tested / fixed / documented. See e.g. this confusing comment: https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/DirectionalLight.svelte#L27-L28 of course I can, so... ???

check / fix / polish
clarify
verify

what? 👀 https://github.com/vatro/svelthree/blob/8fb54d28b52b43532b15600bd01d4712f2032ed6/src/components/LoadedGLTF.svelte#L189-L199

new feature
clarify
refactor