Martin Valgur

Results 231 comments of Martin Valgur

@Neumann-A `find_package(LAPACK REQUIRED)` fails despite `lapack` being listed as a dependency: ``` CMake Error at /mnt/vcpkg-ci/installed/x64-linux/share/lapack/FindLAPACK.cmake:522 (message): A required library with LAPACK API not found. Please specify library location. ```...

> @valgur Is there any new progress? I have been focusing on #39389 lately. Since that one is now complete and ready as far as I'm concerned, I'll be looking...

Fixed the incomplete CUDA support. Builds without issues now for `x64-windows` with ``` vcpkg install suitesparse-cholmod[cuda-redist] suitesparse-spqr[cuda-redist] ceres[suitesparse] g2o colmap[cuda-redist] theia ```

@MonicaLiu0311 Weird. I used the latest CUDA v12.5 on both Windows and Linux.

I added a `ci.baseline.txt` exception for `suitesparse-graphblas`, but the CI pipeline now fails with: > Check For Common Mistakes / Check (pull_request): GitHub Actions has encountered an internal error when...

The PR is broken by seemingly unrelated failures due to `python2` not being found in `graphqlparser`, which the port does not touch. I don't currently have any ideas regarding what...

Use `3.4.0.cci.20240315` as the version name instead. The naming scheme for unofficial releases on CCI was recently updated by the team: https://github.com/conan-io/conan-center-index/pull/24769#discussion_r1704499667

LGTM, but why that specific version instead of the latest commit, though? onnxruntime currently uses a much older version altogether: https://gitlab.com/libeigen/eigen/-/commit/e7248b26a1ed53fa030c5c459f7ea095dfd276ac

I agree with @mayeut. Besides onnxruntime, I have depended on a pre-release version of Eigen in all CUDA projects that make use of it, since it gets rid of a...

@eyalroz The previous PR most likely did not get any attention due to the CI failure. Since this one is passing and a very straightforward change to the recipe, it...