Toni

> @utoni , if it is ok with you, I would like to carefully review this change. It may take some days, because it is holiday time in Italy... Take...

> Can I share the session in some (semi) public forums? I would like to ask some questions about this trace Yea, it is already public.

Your solution seems better. Mine was just a quick fix for classification. Further dissection did not work.

Can you provide more information under what circumstances that NUL deref may happen? Maybe a PCAP?

AFAIK default ports are used for protocol guessing and a risk flag (protocol on non-standard port). The protocol classification routines are running independent of any default port.

> rebased on top of `master` now that #18880 is merged > > @utoni it would be great if you could give your feedback on this one. Even a "fine...

@xdarklight Mausezahn does not get build, so install fails.

@xdarklight ``` install: cannot stat '/home/toni/git/openwrt/build_dir/target-arm_cortex-a9+vfpv3-d16_musl_eabi/netsniff-ng-0.6.7/mausezahn/mausezahn': No such file or directory make[3]: *** [Makefile:95: /home/toni/git/openwrt/bin/packages/arm_cortex-a9_vfpv3-d16/packages/mausezahn_0.6.7-2_arm_cortex-a9_vfpv3-d16.ipk] Error 1 make[3]: Leaving directory '/home/toni/git/openwrt-feed-packages/net/netsniff-ng' time: package/feeds/packages/netsniff-ng/compile#0.14#0.07#0.19 ERROR: package/feeds/packages/netsniff-ng failed to build. ``` I...

I am getting some linker errors while running: `make -C ../openwrt package/netsniff-ng/{clean,compile} -j1 V=s VERBOSE=1` See build log attachment. [nzuu.txt](https://github.com/openwrt/packages/files/9234781/nzuu.txt) or [here](https://termbin.com/nzuu)

@xdarklight Forgot to rebase to the master branch, sorry. Everything works now.