nDPI icon indicating copy to clipboard operation
nDPI copied to clipboard

Improved QUIC IETF 0-RTT detection.

Open utoni opened this issue 3 years ago • 5 comments

Signed-off-by: lns [email protected]

utoni avatar Aug 09 '22 18:08 utoni

@utoni , if it is ok with you, I would like to carefully review this change. It may take some days, because it is holiday time in Italy...

BTW, the session you attached is from real traffic?

IvanNardi avatar Aug 09 '22 18:08 IvanNardi

Can I share the session in some (semi) public forums? I would like to ask some questions about this trace

IvanNardi avatar Aug 09 '22 19:08 IvanNardi

@utoni , if it is ok with you, I would like to carefully review this change. It may take some days, because it is holiday time in Italy...

Take all the time you need. Enjoy your work-free time.

BTW, the session you attached is from real traffic?

Yes.

utoni avatar Aug 09 '22 19:08 utoni

Can I share the session in some (semi) public forums? I would like to ask some questions about this trace

Yea, it is already public.

utoni avatar Aug 09 '22 19:08 utoni

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 18 '22 09:08 sonarqubecloud[bot]

I proposed another solution to this issue in #1713. The main advantage is that it correctly decode the Initial/CH received after the 0-RTT, allowing sub-classification What do you think?

IvanNardi avatar Aug 24 '22 08:08 IvanNardi

Your solution seems better. Mine was just a quick fix for classification. Further dissection did not work.

utoni avatar Aug 24 '22 09:08 utoni