urugator
urugator
@guochengcheng04 Yes because `componentDidMount` is called on different component instance, than the one that throws the error. This is what happens: React creates component instance (+ reaction), renders for the...
I think you're correct the example is wrong. Maybe I am missing something , but the whole idea that you can supress reaction like this seems weird. Perhaps it was...
One observation from today: If you run `yarn install --frozen-lockfile`, it still modifies `yarn.lock`, because it also runs `prepare` script, which calls `yarn install` and `yarn dedup` (without the flags).
> Would it be possible to define displayName on the memo as a bidirectional computed property (set and get) which would just proxy the underlying wrappedComponent's displayName? Unless something changed,...
I see, well that settles my concern above - we will just respect the original component `name` - if it's nameless we keep wrapper nameless as well, so that `displayName`...
https://github.com/mobxjs/mobx/pull/3590/commits/f239cb4b3e210b9e4c966d360485e3a24841afc7 feedback welcome
IIRC the name/displayName handling of `observer(Cmp)` should be currently the same as `React.memo(Cmp)`, so you can only change the name if the original component is inlined, like `observer/memo(() => {})`...
Great, now it fails on https://github.com/facebook/jscodeshift/issues/424
I am not strictly opposed, but I think it has some negatives, while I am not sure about benefits. 1) Second way to do the same thing. 1) How will...