urugator
urugator
> My main issue with this behavior is that it's obscure It's obscure in exactly the same way as with any other non-primitive value in mobx: ```ts const ob =...
Yes, that's an oversight. I assume it's fixable for `observable(fn)`, but I don't know about deep conversions done by enhancer as we seem to have the same problem with `Array/Set/Map`:...
You still have to call `makeObservable(this)` in constructor: https://mobx.js.org/migrating-from-4-or-5.html#upgrading-classes-to-use-makeobservable There is a tool to help you with migration: https://mobx.js.org/migrating-from-4-or-5.html#upgrading-your-code-with-the-mobx-undecorate-codemod And also eslint rule https://github.com/mobxjs/mobx/blob/main/packages/eslint-plugin-mobx/README.md#mobxmissing-make-observable
I see. I am not completely up to date with these, just slapped the makeObservable in the stackblitz and seemed to work. There was a discussion about this, dunno what...
Do we have tests for inheritance with modern decorators? If the behavior differs in any way from legacy decorators/makeObservable, I would like to see it documented. Eg. legacy decorator/makeObservable don't...
@Matchlighter We do, but they are here: https://github.com/mobxjs/mobx/blob/main/packages/mobx/__tests__/v5/base/make-observable.ts#L622-L1704 not (just) in typescript-decorators.ts
Would you mind creating a PR that just runs prettier so we would merge it first? If not, it's completely fine, just pinpoint me to the changed lines, I assume...
The code below suggests, that any error which isn't explicitely marked as **non**-retriable is retriable, which is also what I am experiencing. https://github.com/tulios/kafkajs/blob/55b0b416308b9e597a5a6b97b0a6fd6b846255dc/src/retry/index.js#L17-L18 But I've got to say the first...
Thank you for the response, looking forward for the documentation updates. > Whether using an array or a string separator, the values are indexed the same in RediSearch. I think...
> But since we're in an action, onBecomeUnobserved will never get called to evict the arguments from the cache. Could also relate to this https://github.com/mobxjs/mobx/issues/2309#issuecomment-678376447 > determine whether we're running...