vulp icon indicating copy to clipboard operation
vulp copied to clipboard

Published 20 hours ago • verified publisher icon upkie

Observe base pose

Open ubgk opened this issue 9 months ago • 4 comments

Should BulletInterface also log the base state?

ubgk avatar May 14 '24 14:05 ubgk

Pull Request Test Coverage Report for Build 9276088929

Details

  • 27 of 27 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 89.569%
Totals Coverage Status
Change from base Build 9269426067: 0.1%
Covered Lines: 1975
Relevant Lines: 2205
💛 - Coveralls

coveralls avatar May 14 '24 14:05 coveralls

Absolutely :+1: Can you add a unit test for it?

It will be similar to ObserveImuOrientation.

stephane-caron avatar May 14 '24 15:05 stephane-caron

Sure — I guess it would also make sense to cover the contact observations from the simulator as well. Right?

ubgk avatar May 14 '24 15:05 ubgk

Absolutely, and I completely forgot to do that when merging that feature :blush:

You don't need to worry about that part, though. I did it, so I test it: https://github.com/upkie/vulp/pull/99 (but if you are around feel free to review the PR :smiley:)

stephane-caron avatar May 14 '24 17:05 stephane-caron

A similar PR for inspiration: https://github.com/upkie/vulp/pull/102

stephane-caron avatar May 28 '24 11:05 stephane-caron