Our-Umbraco-TagHelpers

Our-Umbraco-TagHelpers copied to clipboard

Respect height attributes when provided

2

This PR picks up from where @kahlan88 had got to with regards to respecting height attributes when using a `media-item`. The original pull request and discussion for reference is here:...

stayawakesteve

## `our-tag` This tag helper attribute can be seamlessly integrated with any DOM element within the Razor file. It allows content editors to oversee SEO by designating the appropriate HTML...

AndyBoot

Respect heights

6

- with media-item + ignore-crops flag - respect any height values passed in, including responsive heights This PR should help control rendered crops from `our-img` directly, instead of taking the...

kahlan88

Caching SVG doesn't cache CSS class name and Viewbox settings

1

There is an issue where caching an SVG with a class name (or Viewbox setting) causes the class name to be contained in the cache. If outputting the same SVG...

drpeck

Our-img height

1

We're using `` with `media-item` and responsive `width`s and `height`s. According to [example 4 in the readme](https://github.com/umbraco-community/Our-Umbraco-TagHelpers#example-4) - the helper should output height attribute and in the `srcset` on ``...

kahlan88

```csharp if (!string.IsNullOrEmpty(ImgCropAlias)) { // The element contains a crop alias property, so pull through a cropped version of the original image // Also, calculate the height based on the...

mistyn8

our-svg caches the CSS class

3

For the same SVG I have both ``` ``` With the cache turned on the class attribute is cached and 'foo' is rendered in both locations. I suggest adding the...

drpeck

our-svg default cache can't be overridden

1

If you set the SVG cache to be on in appsettings.config, and then wish to disable it on a specific tag instance then it is not possible. Ideally `InlineSvgTagHelper.Cache` (https://github.com/umbraco-community/Our-Umbraco-TagHelpers/blob/main/Our.Umbraco.TagHelpers/InlineSvgTagHelper.cs#L72)...

drpeck

<our-img> - Alternative src's & prevent upscaling

2

A couple of minor bits to try and include/fix. Firstly is the ability to supply more than one src or media-item so that responsive images can alternate between different images...

AndyBoot

Idea: our-text-if

2

Rather than have: ``` @Model.Heading ``` you can just have ``` ```

drpeck