Our-Umbraco-TagHelpers icon indicating copy to clipboard operation
Our-Umbraco-TagHelpers copied to clipboard

Published 20 hours ago • verified publisher icon umbraco-community

Respect height attributes when provided

Open stayawakesteve opened this issue 1 year ago • 2 comments

This PR picks up from where @kahlan88 had got to with regards to respecting height attributes when using a media-item.

The original pull request and discussion for reference is here: https://github.com/umbraco-community/Our-Umbraco-TagHelpers/pull/66

stayawakesteve avatar Oct 05 '23 10:10 stayawakesteve

I'd love to see this one reviewed too if possible. I can't review myself as the starting point for this PR came from my code changes!

kahlan88 avatar Oct 17 '23 13:10 kahlan88

@AndyBoot, @mistyn8, @warrenbuckley is there any chance you could review this PR soon? We found a workaround to use it in our code, but we'd find it really useful if it was part of the package.

There's more detail in https://github.com/umbraco-community/Our-Umbraco-TagHelpers/pull/66 (but we abandoned #66 and continued here).

Thanks!

kahlan88 avatar Nov 22 '23 11:11 kahlan88