Our-Umbraco-TagHelpers icon indicating copy to clipboard operation
Our-Umbraco-TagHelpers copied to clipboard

Published 20 hours ago • verified publisher icon umbraco-community

our-svg default cache can't be overridden

Open drpeck opened this issue 1 year ago • 1 comments

If you set the SVG cache to be on in appsettings.config, and then wish to disable it on a specific tag instance then it is not possible.

Ideally InlineSvgTagHelper.Cache (https://github.com/umbraco-community/Our-Umbraco-TagHelpers/blob/main/Our.Umbraco.TagHelpers/InlineSvgTagHelper.cs#L72) would be nullable, and it would respect a true/false value before considering the appsettings.config value.

drpeck avatar Apr 28 '23 10:04 drpeck

Hiya @drpeck Would you be interested in doing the fix in a PR and perhaps update the unit test to ensure this scenario & the other issue with our-svg in #58 ?

warrenbuckley avatar May 05 '23 12:05 warrenbuckley