Unai Martinez-Corral
Unai Martinez-Corral
> If I understand the failing task, it is not related to my change. Can anyone check this please? It seems that Sphinx was updated to v.4.4.0 and it is...
@eschmidscs I fixed doc issues in `master`. If you rebase, it should be green.
@LarsAsplund the main purpose of this PR is to remove https://github.com/VHDL/Compliance-Tests/blob/master/run.py#L30-L69 by using `--keep-compiling` in order to run the tests which could be compiled. If we force the return code...
> I think that use case is perfectly valid but do you really want the default behavior for a failing compliance test to be return code = 0? Only in...
@GlenNicholls if modelsim is not using the `.exe` to call binaries on Windows, I agree it should be fixed. Some environments, such as MSYS2, can handle executables without extension (e.g....
> * What does the `p` mean after 2008 or 2002 in a package name ? Is it like "for 2002 (or 2008) and newer standards ? Yes. It means...
@LarsAsplund yes. We might consider it a not-so-relevant breaking change. However, since we have other breaking changes in the queue, and it's been half a year since the last release,...
I think it's because VHDL is not case sensitive. See #77 and https://github.com/VUnit/vunit/commit/8360eaaba2dc338f7f59d56f6f950650fd9c5d1a. It might be sensible to revisit that fix taking SV into account.
@std-max, using the trim function in the json4vhdl example sounds as a good solution to me. Will you please propose a PR? > However, that does not solve the problem...
@std-max do you mind adding some test to make this fix is necessary? I.e., the test should fail without this commit, but pass with it.