vunit icon indicating copy to clipboard operation
vunit copied to clipboard

Improving regexs that scan attributes

Open std-max opened this issue 2 years ago • 5 comments

Fix #670

std-max avatar May 31 '22 15:05 std-max

Apparently a check failed but @LarsAsplund you have already fixed it in #835

std-max avatar May 31 '22 15:05 std-max

@std-max Yes, the latest version of Sphinx is a new major version and comes with some backward compatibility breaking changes which I fixed. That is shortly on the master branch and then you can rebase.

LarsAsplund avatar May 31 '22 19:05 LarsAsplund

CI looks good after rebasing :)

std-max avatar May 31 '22 21:05 std-max

@std-max do you mind adding some test to make this fix is necessary? I.e., the test should fail without this commit, but pass with it.

umarcor avatar Jun 01 '22 14:06 umarcor

Yes, I will add some tests when I have a bit of time 👍

std-max avatar Jun 14 '22 13:06 std-max