Benjamin Uekermann comments

Results 295 comments of


                                            Benjamin Uekermann

Rename `use-qr-decomposition` to something more appropriate

I like the subtag idea :+1: Makes things also easier to read, no?

Remove Multi- and BiCouplingScheme

Closing for now as we decided against this refactoring.

Exchanging data without write-data tag leads to an assertion

Yes, throwing an error in such a case should be doable. (ideally already during (post-)configuration, not in `sendData`, we should keep the assertion there)

Use consistent naming scheme for event names

I believe this is part of a bigger problem. We need some convention (and document) how events should be named.

Allow constant underrelaxation with individual relaxation factors per data

Wouldn't this lead to an inconsistent state, e.g. displacement and velocity values do no longer fit together? Could you give an example where this would be meaningful?

Add reduced Quasi Newton acceleration (rQNWR) for waveform iterations

Did you ever think about using a fixed uniform user-defined time grid within each time window for the QN matrices (e.g. 5 slices) and interpolate the new data always on...

Add reduced Quasi Newton acceleration (rQNWR) for waveform iterations

> Replaced by #2005, since this rQNWR algorithm is to complex from a programming perspective to maintain. The pull request in #2005 only use 1 time grid inside QNWR method...

Sending zero displacements in a serial-implicit coupling crashes precice (perpendicular-flap tutorial)

Thanks for the detailed analysis, everybody! If the QN system runs empty, we could do an underrelaxation step again. This was the original idea in #1510 But probably beyond v3.0.0

Sending zero displacements in a serial-implicit coupling crashes precice (perpendicular-flap tutorial)

Using a preconditioner when there is only one data vector in the acceleration is anyway useless. Maybe we could forbid this or switch off automatically.

Sending zero displacements in a serial-implicit coupling crashes precice (perpendicular-flap tutorial)

> The problem above would persist though. You mean that it would also happen if multiple data fields are used in acceleration and all of them are zero, right? I...