Benjamin Uekermann
Benjamin Uekermann
Sound good to me :+1:
Useful to keep in mind is the difference between primary data and coupling data: https://precice.org/configuration-acceleration.html We want to use the last time step of a window to compute the acceleration,...
For me, this is clearly a bug and not a usability concern. This has never been a legal configuration and would surely lead to a crash somewhere. Adding a check...
> I could imagine the perpendicular flap moving back and forth, to connect it with an existing tutorial. Something rotating would actually be even nicer. Like a rotating flexible cylinder.
Thanks for the nice modification and documentation :pray: I would indeed suggest to split the PR into two. The fluid modifications and the new solid participant. The latter should be...
> Different CPUs and optimization for different CPUs This can indeed lead to floating-point differences. But I don't understand the title here, `RelTol` should be the solution, no?
Do the tests run with `3e-7`? I guess, we should be able to go smaller, but will be try-and-error. Everything we do is double precision, so sth like `1e-13` should...
This could very well be on purpose, to be able to read the displacement values on all ranks. A common hack. See also: https://precice.org/couple-your-code-distributed-meshes.html Not saying that one could not...
I guess we can reproduce the problem with this docker file: https://github.com/uekerman/Coupled-Brittle-Fracture/blob/master/brittle-fracture.dockerfile
For pip noobs (like me), the workaround is: ``` pip3 uninstall -y fenics-ufl ```