Mark Tyneway
Mark Tyneway
> It'll be good to update the Portal2 post checks to further ensure that we don't accidentally reuse that slot for something else. Relying on human review for storage slot...
This generally looks good to me but no test coverage
> > This generally looks good to me but no test coverage > > Yeah, I don't think this file has any test coverage at all. What do you think...
@sebastianst I have addressed all open comments on this PR
> Seeing failures in the `SystemConfig_Initialize_TestFail` and `SystemConfig_Initialize_Test` suites, possible related to the conflict in differential-testing.go? I have rebased
> `scalar` and `overhead` removal lgtm! we can always add back if necessary. Looks like `op-e2e` depends on pre-ecotone execution, meaning that we cannot fully get rid of these without...
The legacy setter will need to be called for tests that don't run with ecotone enabled
I have addressed merge conflicts with a rebase
Can you give a reproducible case that shows this error? Imports using this style are part of our style guide. They make refactoring much easier internally to the project. Perhaps...
Thank you for the repro case