maint(ct): clean up periphery deploy script

[smartcontracts]

Cleans up the deploy script for periphery contracts. Script was a bit messy and we need a cleaned up version so that we can safely deploy and manage Drippie for the Challenger.

[coderabbitai[bot]]

[!WARNING]

Rate Limit Exceeded

@smartcontracts has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 32 minutes and 33 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between e062e73c91c8d2dcbc7bd4da6cf25a412f9682d7 and 19ddd43b41b0236bd18c5648da309bfeede7a6a2.

Walkthrough

The recent update involves enhancing the testing suite for the DeputyGuardianModule in the contracts-bedrock package. Logging statements were added to improve visibility of function and contract names during test execution. This enhancement aids in debugging and ensuring clarity when running multiple tests in sequences or loops.

Changes

File Path	Change Summary
.../test/Safe/DeputyGuardianModule.t.sol	Added logging for contractName and fnName in test loops.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.26%. Comparing base (e038117) to head (19ddd43). Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #10276      +/-   ##
===========================================
- Coverage    42.40%   39.26%   -3.14%     
===========================================
  Files           73       27      -46     
  Lines         4830     1821    -3009     
  Branches       766      415     -351     
===========================================
- Hits          2048      715    -1333     
+ Misses        2676     1106    -1570     
+ Partials       106        0     -106     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	?
contracts-ts-tests	?
core-utils-tests	?
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

[tynes]

This generally looks good to me but no test coverage

[smartcontracts]

This generally looks good to me but no test coverage

Yeah, I don't think this file has any test coverage at all. What do you think is the best way to add coverage?

[refcell]

I wonder if we could use interfaces to assert the behavior of at least a portion of the functions in the script.

[tynes]

This generally looks good to me but no test coverage

Yeah, I don't think this file has any test coverage at all. What do you think is the best way to add coverage?

An easy way would be to use the deploy script to set up the contracts for their unit tests