Mark Tyneway

Results 344 comments of Mark Tyneway

The problem is here: ```js const l1Signer = l1Provider.getSigner(0) ``` You must connect a `ethers.Wallet` to the provider instead of using a remote signer. Using `eth_sendTransaction` is not supported

See this comment for fixing the tests: https://github.com/ethereum-optimism/optimism/blob/4a5e1832686f1375be3fb1b20768a67625455d68/packages/sdk/tasks/deposit-erc20.ts#L78-L80

Hoping that https://github.com/ethereum-optimism/optimism/pull/3199 fixes the issues we are seeing in CI when it hangs sometimes

I've rebased this and then updated the name to `MemorySafeCall`

@smartcontracts Just rebased and fixed the merge conflict

It appears as if both of these queries came from before the regenesis as both of the commands that you pasted resulted in transaction/block not found. I was able to...

The root cause is that queue origin L1 to L2 transactions (sent via `enqueue`) do not have a `from` and do not increment a nonce in the state. The queue...

> @tynes Thanks for your review, it there any update on this? Hey @jsvisa appreciate all the work that you did to backport this. The diff is massive and I...

A more compute heavy but decoupled from implemention way to do this would be a binary search for the code. Then changes to the address manger wouldn't ever break discovery...