optimism icon indicating copy to clipboard operation
optimism copied to clipboard

Published 20 hours ago • verified publisher icon ethereum-optimism

feature: backport l2geth with go-ethereum native trace v1.10.20

Open jsvisa opened this issue 2 years ago • 5 comments

Description A clear and concise description of the features you're adding in this pull request.

Additional context Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

jsvisa avatar Jul 26 '22 11:07 jsvisa

⚠️ No Changeset found

Latest commit: 178f09b23a99a5a3ae24126d5b66aa26fef6040e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 26 '22 11:07 changeset-bot[bot]

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

mergify[bot] avatar Jul 26 '22 11:07 mergify[bot]

@tynes Thanks for your review, it there any update on this?

jsvisa avatar Jul 29 '22 15:07 jsvisa

@tynes Thanks for your review, it there any update on this?

Hey @jsvisa appreciate all the work that you did to backport this. The diff is massive and I do not think we will be able to merge it in this state. We are open to the idea of cutting a special release from this branch that community members can try at their own risk because we know that tracing has been difficult. If there is a bug in here, it would be basically like introducing a hardfork into the protocol and we do not want to risk that right now with an upcoming upgrade to the system.

tynes avatar Aug 09 '22 23:08 tynes

@tynes thanks for your advice, and looks good to me. BTW, in our infra, we can run ethereum-etl on the two branches, and compare the difference.

jsvisa avatar Aug 10 '22 02:08 jsvisa

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 03 '22 02:09 github-actions[bot]

any update？

jsvisa avatar Sep 04 '22 00:09 jsvisa

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 18 '22 02:09 github-actions[bot]

Hey there!

After conferring with the team, I'm going to close this PR. The team is all-hands-on-deck with the Bedrock upgrade, and we don't have the bandwidth right now to review such a large and high-risk diff carefully enough.

That said, if anyone needs these fixes prior to Bedrock launching and is willing to take on the risk of using themselves, we'll direct them to your branch.

We very much appreciate the effort here - if we weren't so close to the Bedrock finish line, we'd strongly consider merging this in.

mslipper avatar Sep 18 '22 14:09 mslipper