Till Maas

Support upstream SOCKS proxy

33

Implement support for SOCKS upstream proxy with DNS resolution via SOCKS, so mitmproxy can be easily tunnelled through "ssh -D".

Investigate issue with package installation

15

There is a commit in a fork that indicates there is a problem with package installation https://github.com/youviewtv/galaxy-network-role/commit/d5d769ec5896f429cb5fc1a97ad3f7dd2823a2e7 This needs investigation.

Include vlan: id: 123 in README.md

3

https://github.com/linux-system-roles/network/blob/main/README.md#type-vlan needs to document how to specify the VLAN id (and other vlan settings if there are any).

add example how to run/use the role

6

The README is missing some basic information about how to install/use the role. It should probably mention how to use ansible-galaxy, what is needed to run from GIT and how...

The role ships a module (network_connections.py). It is not supported to use this directly but an internal implementation details. This should be mentioned in the README. It might also be...

https://github.com/linux-system-roles/network/blob/main/scripts/print_all_options.py allows to create an overview of all settings the role accepts. Use this to create an overview (maybe in the appendix) of the documentation and integrate this into the...

There is some tooling to provide coverage information for integration tests: https://github.com/linux-system-roles/network/blob/main/tests/get_total_coverage.sh Currently, this information is not yet used in the CI/not reported anywhere. It would be great to also...

Make yamllint config more strict

1

the truthy and document_start checks are currently disabled in yamllint by the system roles default template but they could be enabled for the network role The truthy check also allows...

Change ethtool features to use underscore instead of dashes

1

As discussed in https://github.com/linux-system-roles/network/issues/189#issuecomment-618020499, the ethtool features should use underscores instead of dashes. Since we already introduced the names with dashes, they need to be supported. Implementation plan: - [x]...

don't compare booleans, this was fixed only very recently: https://github.com/pallets/jinja/issues/813

4

don't compare booleans, this was fixed only very recently: https://github.com/pallets/jinja/issues/813 _Originally posted by @pcahyna in https://github.com/linux-system-roles/network/pull/232/files_