Trevor Currie

Results 21 comments of Trevor Currie

Sorry, this was resolved with the PR #96, but a new release wasn't published. We'll follow up with that and publish the latest as a release.

@laurentS I have the start of a branch to do so, but at a minimum, you'll need to put some pypi credentials as a repo secret.

Due to personal reasons, I won't have any github action based release process PR ready soon. @laurentS will need to manually issue the release.

I'm uncertain about whether using `_` as a parameter is a positive change. To resolve linter errors, I'd instead encourage the annotation `# noqa`. From the library perspective, I'd rather...

I agree, I think it's a bit clunky of a user experience. I think the proposal to shift this into an [ASGI middleware implementation ](https://github.com/laurentS/slowapi/issues)would remove the need to declare...

There are [headers injected ](https://github.com/laurentS/slowapi/blob/master/slowapi/extension.py#L354-L405)to the response that provide some of that information. It's enabled within the `__init__` of the Limiter, just [set to false by default](https://github.com/laurentS/slowapi/blob/master/slowapi/extension.py#L141).

To elaborate, the generated OpenAPI docs available for the service at `/docs` (or `/redocs`?) do not show that 429 is a possible response for an endpoint with the rate limiter...

I'd need to review the internals of FastAPI's docs generation to identify a way to hook into that process, but I agree, that should be surfaced within the OpenAPI documentation.

Thanks @laurentS. Happy to help.

This appears to be the implementation approach for this other [rate-limiting library](https://github.com/long2ice/fastapi-limiter) for FastAPI.