slowapi icon indicating copy to clipboard operation
slowapi copied to clipboard

Redis Version Conflict: install failed when redis > 4.0

Open a-yangyi opened this issue 3 years ago • 9 comments

The conflict is caused by: The user requested redis==4.2.0rc3 slowapi 0.1.5 depends on redis<4.0.0 and >=3.4.1

a-yangyi avatar Mar 25 '22 03:03 a-yangyi

Since redis is just an optional backend it might make sense to have it as an extra: https://python-poetry.org/docs/pyproject#extras

Otherwise if you use a later version of redis for another package you need to downgrade even if you don't want to use the redis backend.

Walheimat avatar Mar 31 '22 14:03 Walheimat

Any update on this?

salsudeer avatar Jul 19 '22 15:07 salsudeer

This is still causing issues, maybe remove the redis version requirement? I see that the limits package supports redis >3 and <5. Is it necessary to have it in the pyproject.toml though? @laurentS

xbogdan avatar Jul 27 '22 09:07 xbogdan

Sorry, this was resolved with the PR #96, but a new release wasn't published. We'll follow up with that and publish the latest as a release.

twcurrie avatar Jul 27 '22 22:07 twcurrie

Hi all, sorry for the lag. I am still the only person who can push a release. I will try to make one in the next few days, and find a way to make the release process go through github actions, so that any maintainer of the repo can create one going forward.

laurentS avatar Jul 29 '22 10:07 laurentS

@laurentS I have the start of a branch to do so, but at a minimum, you'll need to put some pypi credentials as a repo secret.

twcurrie avatar Jul 29 '22 11:07 twcurrie

@twcurrie brilliant! Feel free to open a PR whenever you're happy with your code. I'd really like to make it so that there is no single bottleneck in the maintenance of this repo (particularly me!).

laurentS avatar Jul 29 '22 11:07 laurentS

Hi all, sorry for the lag. I am still the only person who can push a release. I will try to make one in the next few days, and find a way to make the release process go through github actions, so that any maintainer of the repo can create one going forward.

Waiting for it 🙏

salsudeer avatar Aug 02 '22 07:08 salsudeer

Due to personal reasons, I won't have any github action based release process PR ready soon. @laurentS will need to manually issue the release.

twcurrie avatar Aug 02 '22 08:08 twcurrie