Thomas Clegg

Results 34 comments of Thomas Clegg

It seems that all those phone numbers are invalid URL country_code_source appspot result csharp result http://libphonenumber.appspot.com/phonenumberparser?number=%2B55999830563&country=BR FROM_NUMBER_WITH_PLUS_SIGN isValidNumber -> false `+55 999830563` http://libphonenumber.appspot.com/phonenumberparser?number=%2B00932905150&country=AF FROM_NUMBER_WITH_IDD isValidNumber -> false `NumberParseException` http://libphonenumber.appspot.com/phonenumberparser?number=%2B542018587&country=AR FROM_NUMBER_WITH_PLUS_SIGN...

That number in NSN with country code and E164 both show as valid with even with versions of the library at least a year old. https://dotnetfiddle.net/CXvwYF

Sorry, I confused this with an issue filed yesterday. This I'll to try to make some time to better dig into the issue. and National Significant Number

This library intends to match the behavior the the Google's Java version https://github.com/google/libphonenumber/blob/master/java/libphonenumber/src/com/google/i18n/phonenumbers/CountryCodeToRegionCodeMap.java feel free to file an issue with them https://github.com/google/libphonenumber/blob/master/CONTRIBUTING.md

The same result shows here https://libphonenumber.appspot.com/phonenumberparser?number=%2B598+1987+0000 please open the issue with Google https://github.com/google/libphonenumber/blob/master/CONTRIBUTING.md#filing-a-metadata-issue

@swtanggara The port is most certainly lacking compared to the source. I've been working to bring it up to parity since I took over keeping it up to date. If...

It hasn't been a priority given that there hasn't been any discussion for this is quite a while. It does seem like it should be straightforward enough to port though,...

That is an invalid number, perhaps famously so https://en.wikipedia.org/wiki/555_(telephone_number) See the behavior here https://libphonenumber.appspot.com/phonenumberparser?number=%2B15555555555

There are plans for it and it is partially done in https://github.com/twcclegg/libphonenumber-csharp/pull/45. I have yet to find the time to get back to that, it needs to get split up...

Is there an issue that you are facing? The [unit tests](https://github.com/google/libphonenumber/tree/master/resources/test/geocoding) purposely do not contain the [full metadata](https://github.com/google/libphonenumber/tree/master/resources/geocoding). It seems like it is working fine here https://dotnetfiddle.net/ri6Thm