Thomas Clegg

Results 34 comments of Thomas Clegg

It appears that `csharp/PhoneNumbers/LocaleData.cs` was quite out of date and was missing SX data. This should be resolved in the 8.12.53 release. Please let me know.

Unfortunately, at least for now, the library is in basically maintenance mode with updates to metadata.

It returns a Dictionary.KeyCollection which is a list of sorts, though it probably should be a proper List. As for the data itself, I'll look into it, in the meantime...

I believe I have an idea of how this could be done. Let me get back to you.

It could almost work to make `PhoneNumberUtil.GetInstance()` take a `RegexOptions?` as an optional param; however that involves making all of currently static regexs non-static which per my understanding would mostly...

I could look into finding some sort of auto translator, any javadoc is what was copied from Google source when the code was ported. I haven't paid much if any...

I looked, albeit briefly, and didn't find anything I can start doing this for future code functionality that is ported, and I am definitely open to any contribution.

My understanding of those fields is that they both would be `internal` however `PhoneNumber` is generated from a proto which means everything is public. `PhoneNumberUtil.Parse` always sets both if it...

Hi there, any support is always appreciated. The regexs almost certainly are the bottleneck, there's been some work to make things faster https://github.com/twcclegg/libphonenumber-csharp/pull/121. Master would be the place for any...

Thank you for the test build, it seems like it did indeed point to an issue: `C:\Users\tclegg\.nuget\packages\altcover\8.3.702-github-pre\build\netstandard2.0\AltCover.targets(83,5): warning : Null Primitive Constant in method System.Void ./d__43::MoveNext()`, where `thing` is `const...