TJ Egan

Results 89 comments of TJ Egan

Seems like this is due to `...getTableProps()` on `Table` being called _after_ the prop is added to the component. I'm not too sure how all the demos are rendered though...

This was added in https://github.com/carbon-design-system/carbon-website/pull/1706 and was approved @dakahn just making sure removing this label won't cause any a11y issues?

After removing the label it looks like it does cause an issue with the a11y checker:

Changes look good to me! Since you say > If you're using `@carbon/react` there's no reason to install the themes package separately. See our [Carbon React](/developing/frameworks/react/) guide to start does...

This is related to https://github.com/carbon-design-system/carbon/issues/8460. I believe the easiest fix is to update the selector [here](https://github.com/IBM/carbon-components-angular/blob/master/src/search/search.component.html#L37) to `bx--search-magnifier-icon`

cc @carbon-design-system/design for guidance

@aagonzales good catch, updated to fix that 👍🏻

FWIW, adding `data-floating-menu-container` to the `OverflowMenu` itself seems to retain the focus order ![2021-08-24 12 00 46](https://user-images.githubusercontent.com/11928039/130597821-f7d1b98a-b2d2-48c5-87bf-8afdd1b7d984.gif)

@carbon-design-system/developers should this be an application-level fix or should the Overflow menu have a higher z-index than the side-nav at all times? Not sure if this will have unintended consequences.