carbon-website icon indicating copy to clipboard operation
carbon-website copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

bug[live demo component]: remove field label from above dropdown

Open jeanservaas opened this issue 3 years ago • 3 comments

regression[live demo component]: remove field label from above dropdown

I'm assuming this is a regression of some kind. That field label was never in the spec and it wasn't in the approved merge either. We need to remove it please.

image

jeanservaas avatar Jan 28 '21 00:01 jeanservaas

This was added in https://github.com/carbon-design-system/carbon-website/pull/1706 and was approved

@dakahn just making sure removing this label won't cause any a11y issues?

tw15egan avatar Jan 28 '21 18:01 tw15egan

After removing the label it looks like it does cause an issue with the a11y checker:

Screen Shot 2021-01-28 at 10 13 47 AM

tw15egan avatar Jan 28 '21 18:01 tw15egan

change was added here. Looks it got two devs to sign off and Kodiak (a bot) just auto merged it 🦊 That's my bad.

Should have caught that pre-emptive ready to merge tag. We can revert this change, but like @tw15egan mentioned we will fail AVT. An alternative to a distinct visual label is appending the components label like this: inline-label-github

@andreancardona is working on this exact solution for an AVT error on the component index page. Can we just use that here?

dakahn avatar Feb 03 '21 00:02 dakahn

Replaced with storybook demo https://github.com/carbon-design-system/carbon-website/pull/3716

alisonjoseph avatar Sep 08 '23 15:09 alisonjoseph