Tamas Vami comments

Results 386 comments of


                                            Tamas Vami

High level issue for building v15 geometry

I did what I could, I have no idea how to do the light pipes, SiPMs, and support structure so somebody else will have to do that

Potential out-of-bounds memory in IdealClusterBuilder

Could be false-postive? @EinarElen wdyt?

Potential out-of-bounds memory in IdealClusterBuilder

Yes it is compiler, but I noticed it in the ASAN build

Potential out-of-bounds memory in IdealClusterBuilder

hi @therwig did you write this class? I also tried to add some of it in the logging system and get rid of the Printouts in https://github.com/LDMX-Software/ldmx-sw/pull/1800 but it lead...

Potential out-of-bounds memory in IdealClusterBuilder

I think if you do ``` just configure-asan-ubsan just build just fire .github/validation_samples/ecal_pn/config.py ``` the "potential out-of-bounds" should come up! Altho I did test that recently. What I tried to...

Acts ParticleHypothesis assert fail

@bloodyyugo FYI

Acts ParticleHypothesis assert fail

I made a PR where it's configurable and only the positive is used https://github.com/LDMX-Software/ldmx-sw/pull/1886

Introduce a G4 based generator interface with LHE

@tomeichlersmith maybe you can add more about the "Describe the solution you'd like"?

Modified the LYSO target design

> if we should have a validation workflow for geometry changes? I agree we need this, but I think we should have this after the sensitive volumes are defined, then...

Modified the LYSO target design

I'd like to point out that 1) This doesnt validate the geometry (we cant until https://github.com/LDMX-Software/ldmx-sw/issues/1533 is resolved) 2) This does check that passive element part, but then how different...