Tamas Vami
Tamas Vami
After this issues is resolved, I propose we change https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Framework/include/Framework/Event.h#L390 ``` const std::string &passName = "") const { ``` to ``` const std::string &passName) const { ``` so people will...
This is resolved in https://github.com/LDMX-Software/ldmx-sw/pull/1708
> the number of events used in the CI should not be a driving factor in this logic. Yeah I agree, my point was not to hardcode any number, but...
@bryngemark can you help me to understand the choice for the lower end, why is it 20 and not just 0 (or 1)?
I need to digest this a bit more, are you saying that it doesnt actually matter what's in the GDML, if the GDML has z =10 but the geometry has...
@tomeichlersmith can you give me the historic reasoning on why we wouldn't just have ``` G4ThreeVector position = 0.5 * (prePoint->GetPosition() + postPoint->GetPosition()); hit.setPosition(position[0], position[1], position[2]); ```
it's even in the comments "It would probably help us more if we persisted the actual simulated position of the hit rather than the cell center; however, that is up...
(I can also make a separate issue about this)
> (I can also make a separate issue about this) Let's continue this in https://github.com/LDMX-Software/ldmx-sw/issues/1484
with the verbosity increased, this is what I see in the `G4cerr.log` ``` -------- EEEE ------- G4Exception-START -------- EEEE ------- *** G4Exception : InvalidRead issued by : G4GDMLRead::Read() ERROR -...