Tamas Vami
Tamas Vami
I think https://github.com/LDMX-Software/ldmx-sw/pull/1548 resolved this (together with https://github.com/LDMX-Software/ldmx-sw/pull/1245 )
For the records, done in https://github.com/LDMX-Software/ldmx-sw/pull/1362
> Ecal veto buffer overflow missing .size() I put the tick in for this as this was fixed already in https://github.com/LDMX-Software/ldmx-sw/commit/5c6bee2126998962e6af45bae2b4bd0498c4b32f
@EinarElen, when you have some time can you send instruction on how you ran ASAN?
Hey @EinarElen I'm back to this a bit again, I ran ``` ldmx cmake -B build -S . -DENABLE_SANITIZER_ADDRESS=ON ldmx cmake --build build --target install -- -j$(nproc) ``` and it...
OK so good news it that I can ran this. Bad news is that the first thing I see, I have very little idea on what to do with. The...
Ok I did a few `cout`s, indeed it's the one with `maps` indices. A good event ``` index 1304 step 0 dis[0]: -3.40018 dis[1]: 74.6287 index 1304 step 1 dis[0]:...
OK resolved the > Ecal veto mapsx/mapsy in https://github.com/LDMX-Software/ldmx-sw/pull/1410 I have student Ananda who'll look into the noise generation, so in that PR I think we can take the >...
> I'll prob have the DQM one on my next todo list. Ah this was easy, it's already fixed: https://github.com/LDMX-Software/ldmx-sw/blob/trunk/DQM/include/DQM/PhotoNuclearDQM.h#L104 (It was fixed in https://github.com/LDMX-Software/ldmx-sw/pull/1219) I ticked the entry in...
isNoise is fixed in https://github.com/LDMX-Software/ldmx-sw/pull/1434 for the other two I need @EinarElen